Improve rpc errors logging #6362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
friofry
commented
Feb 25, 2025
| } | ||
|
|
||
| // NewProviderStatus processes ProviderCallStatus and returns a new ProviderStatus. | ||
| func NewProviderStatus(res ProviderCallStatus) ProviderStatus { |
There was a problem hiding this comment.
This method was only used in tests.
friofry
commented
Feb 25, 2025
| ) | ||
|
|
||
| // CreateEthClientFromProvider creates an Ethereum RPC client from the given RpcProvider. | ||
| func CreateEthClientFromProvider(provider params.RpcProvider, rpcUserAgentName string) (*rpc.Client, error) { |
There was a problem hiding this comment.
This function is extracted from rpc/client.go to have a clear way of creating rpc.Client from RpcProvider.
| @@ -15,32 +17,77 @@ import ( | |||
| type RPSLimitedEthClientInterface interface { | |||
| EthClientInterface | |||
| GetLimiter() *rpclimiter.RPCRpsLimiter | |||
| GetName() string | |||
| CopyWithName(name string) RPSLimitedEthClientInterface | |||
| GetCircuitName() string | |||
There was a problem hiding this comment.
Name was always a circuit name, so renamed to avoid ambiguity.
Multiple providers can share the same circuit, hence 2 properties Circuit and Provider.
| return NewRPSLimitedEthClient(c.rpcClient, c.limiter, circuitName, c.providerName) | ||
| } | ||
|
|
||
| func (c *RPSLimitedEthClient) ExecuteWithRPSLimit(f func(client EthClientInterface) (interface{}, error)) (interface{}, error) { |
There was a problem hiding this comment.
Extracted this function from rpc/chain/client.go as this logic is more related to RpsLimitedEthClient than chain client.
dlipicar
reviewed
Feb 25, 2025
| @@ -44,6 +44,7 @@ func (a *Aggregator) Update(providerStatus rpcstatus.ProviderStatus) { | |||
| // Update existing provider status or add a new provider. | |||
| if ps, exists := a.providerStatuses[providerStatus.Name]; exists { | |||
| ps.Status = providerStatus.Status | |||
| ps.ChainID = providerStatus.ChainID | |||
There was a problem hiding this comment.
Isn't this layer supposed to be chainID-agnostic? (as in, we don't deal with chainIDs with market providers, but we do once we go into a more specific layer of RPC/collectibles providers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging status-im/status-mobile#22155 I needed more information in the logs.
So this PR addresses 2 issues:
Changes:
Closes #6266