Skip to content

Msvc warning #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radkesvat opened this issue Feb 1, 2025 · 0 comments
Open

Msvc warning #118

radkesvat opened this issue Feb 1, 2025 · 0 comments

Comments

@radkesvat
Copy link

Hi,

I am getting this warning on my local MSVC 2019 setup

(only for x86 build, x64 is ok)

include\stc\common.h(253): warning C4310: cast truncates constant value
include\stc\common.h(258): warning C4310: cast truncates constant value
include\stc\common.h(266): warning C4310: cast truncates constant value

I think we should simply disable it in common.h header as far as i know, i dont have any idea of the hash function being used there
maybe use int64 instead of size_t ...?

if you want i can also submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant