Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanwd #4496

Merged
merged 77 commits into from
Feb 8, 2025
Merged

feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanwd #4496

merged 77 commits into from
Feb 8, 2025
+412 −260

Conversation

Neerajpathak07
Copy link
Contributor

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

  • adds C ndarray interface for stats/base/dsnanmeanwd
  • refactor JavaScript implementation
  • refactor examples, tests, docs and benchmarks.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves none.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Jan 3, 2025
aayush0325 and others added 27 commits January 3, 2025 19:10
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
084f3a6 
…base/dmskmin`

PR-URL: stdlib-js#4371
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
96b79ec 
…base/dmaxsorted`

PR-URL: stdlib-js#4456
Reviewed-by: Athan Reines <[email protected]>
@Snehil-Shah @Neerajpathak07
fix: guard against proxy traps raising exceptions in REPL tokenizer
86b286b 
PR-URL: stdlib-js#4457
Reviewed-by: Athan Reines <[email protected]>
@kgryte @Neerajpathak07
style: add missing parentheses
3da59ed 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: passed
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/smeanli native addon from C++ to C
1dbb675 
PR-URL: stdlib-js#4465
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/smeankbn2 native addon from C++ to C
28cec13 
PR-URL: stdlib-js#4464
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/smeankbn native addon from C++ to C
d0db054 
PR-URL: stdlib-js#4463
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/smean native addon from C++ to C
f24da86 
PR-URL: stdlib-js#4462
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
d08e176 
…base/dminsorted`

PR-URL: stdlib-js#4201
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/sdsnanmeanors native addon from C++ to C
f30ba4a 
PR-URL: stdlib-js#4459
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 @Neerajpathak07
refactor: update stats/base/sdsnanmean native addon from C++ to C
1c42575 
PR-URL: stdlib-js#4458
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
c22a02c 
…base/smskmin`

PR-URL: stdlib-js#4403
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
605cc35 
…base/dmediansorted`

PR-URL: stdlib-js#4466
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
b985c04 
…base/smaxsorted`

PR-URL: stdlib-js#4481
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
0d709e2 
…base/dmskmax`

PR-URL: stdlib-js#4366
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@DhruvArvindSingh @Neerajpathak07
refactor: update stats/base/snanvariance native addon from C++ to C
29af008 
PR-URL: stdlib-js#4471
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 @kgryte
@stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
b3d3e84 
…base/smskmax`

PR-URL: stdlib-js#4401
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
f63c78f 
…base/dmaxabssorted`

PR-URL: stdlib-js#4181
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@aayush0325 @stdlib-bot @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
55a4c98 
…base/smaxabssorted`

PR-URL: stdlib-js#4479
Reviewed-by: Athan Reines <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
@DhruvArvindSingh @Neerajpathak07
refactor: update stats/base/sstdevtk native addon from C++ to C
6fd7b4a 
PR-URL: stdlib-js#4484
Reviewed-by: Athan Reines <[email protected]>
@DhruvArvindSingh @Neerajpathak07
refactor: update stats/base/snanstdevtk native addon from C++ to C
f4044b7 
PR-URL: stdlib-js#4474
Reviewed-by: Athan Reines <[email protected]>
@DhruvArvindSingh @Neerajpathak07
refactor: update stats/base/snanstdevpn native addon from C++ to C
3277593 
PR-URL: stdlib-js#4475
Reviewed-by: Athan Reines <[email protected]>
@DhruvArvindSingh @Neerajpathak07
refactor: update stats/base/snanstdevyc native addon from C++ to C
24e234a 
PR-URL: stdlib-js#4472
Reviewed-by: Athan Reines <[email protected]>
@DhruvArvindSingh @kgryte @Neerajpathak07
refactor: update stats/base/snanvariancech native addon from C++ to C
d8a7b76 
PR-URL: stdlib-js#4483
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 @kgryte @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
018db3f 
…base/dcumin`

PR-URL: stdlib-js#4144
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@aayush0325 @kgryte @Neerajpathak07
feat: add C ndarray interface and refactor implementation for `stats/…
cc35a07 
…base/dcumaxabs`

PR-URL: stdlib-js#4139
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@Planeshifter @Neerajpathak07
build: do not set custom GitHub token
9e04643 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
kgryte and others added 5 commits January 3, 2025 19:10
@kgryte @Neerajpathak07
chore: update mailmap
54130b1 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Neerajpathak07 @kgryte
feat: add C ndarray interface and refactor implementation for `stat…
7ba862f 
…s/base/dnanmeanwd`

PR-URL: stdlib-js#4251
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@vivekmaurya001 @kgryte @Neerajpathak07
refactor: update math/base/assert/is-even to follow latest project …
d4e3a94 
…conventions

PR-URL: stdlib-js#4183
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
@Neerajpathak07
chore: minor clean up
cee348a
@Neerajpathak07
Merge branch 'ndarray-dsnanmeanwd' of https://github.com/Neerajpathak…
b4c80be 
…07/stdlib into ndarray-dsnanmeanwd
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 3, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dsnanmeanwd $\color{green}402/402$
$\color{green}+100.00\%$ 		$\color{green}23/23$
$\color{green}+100.00\%$ 		$\color{green}4/4$
$\color{green}+100.00\%$ 		$\color{green}402/402$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 3, 2025 17:26
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 3, 2025
@Neerajpathak07 Neerajpathak07 marked this pull request as draft February 1, 2025 13:09
@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review February 1, 2025 13:51
@Neerajpathak07
Copy link
Contributor Author

@aayush0325 Done!

@Neerajpathak07
Copy link
Contributor Author

did the same for the other PR's as well!

kgryte
kgryte approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgryte kgryte changed the title feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanwd feat: add C ndarray interface and refactor implementation for stats/base/dsnanmeanwd Feb 8, 2025
@kgryte kgryte merged commit aacf454 into stdlib-js:develop Feb 8, 2025
13 checks passed
@kgryte kgryte added Feature Issue or pull request for adding a new feature. and removed Needs Review A pull request which needs code review. labels Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@aayush0325 aayush0325 aayush0325 approved these changes

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. Statistics Issue or pull request related to statistical functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Neerajpathak07 @stdlib-bot @kgryte @aayush0325 @Snehil-Shah @vivekmaurya001 @DhruvArvindSingh @Planeshifter @0PrashantYadav0