fix(apply_shim): add nil check for opts #177
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#175 does not check for possible nil value of
opts
onadd_shim
(that may come from:h dressing_get_config()
). Addnil
checkContext
#175 added
apply_shim
to maintain backwards compatibility, but it doesn't check ifopts
isnil
before trying to access it. It may benil
since:h dressing_get_config()
allows for anil
return value.Description
A
nil
check is addedTest Plan
My config was broken after #175 since I have the following on my oil setup.
The function returns
nil
to fallback to the default config whe prompt is notcmd:
. With this config, callingvim.ui.input({}, function() end)
resulted in an error before this PR and works as expected after it.