From fdf203c56cf4d909fe43fe2aca71d296bf164ae6 Mon Sep 17 00:00:00 2001 From: Paul Farver Date: Wed, 8 Jan 2025 17:10:22 +0100 Subject: [PATCH 1/2] fix cert-manager ca injection in vpa mutatingwebhook --- charts/vertical-pod-autoscaler/CHANGELOG.md | 4 ++++ .../templates/admission-controller/webhook.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/charts/vertical-pod-autoscaler/CHANGELOG.md b/charts/vertical-pod-autoscaler/CHANGELOG.md index 9e219b91..d4e642ee 100644 --- a/charts/vertical-pod-autoscaler/CHANGELOG.md +++ b/charts/vertical-pod-autoscaler/CHANGELOG.md @@ -14,6 +14,10 @@ ## [UNRELEASED] +### Fixed + +- Fixed incorrect cert-manager ca-injection target in mutatingwebhookconfiguration + ## [v1.7.1] - 2024-08-22 ### Added diff --git a/charts/vertical-pod-autoscaler/templates/admission-controller/webhook.yaml b/charts/vertical-pod-autoscaler/templates/admission-controller/webhook.yaml index cb3522c0..bf9f48a9 100644 --- a/charts/vertical-pod-autoscaler/templates/admission-controller/webhook.yaml +++ b/charts/vertical-pod-autoscaler/templates/admission-controller/webhook.yaml @@ -23,7 +23,7 @@ metadata: {{- include "vertical-pod-autoscaler.admissionController.labels" . | nindent 4 }} {{- if .Values.admissionController.certManager.enabled }} annotations: - cert-manager.io/inject-ca-from: {{ printf "%s/%s" .Release.Namespace (include "vertical-pod-autoscaler.admissionController.webhookCertSecret" .) }} + cert-manager.io/inject-ca-from: {{ printf "%s/%s" .Release.Namespace (include "vertical-pod-autoscaler.admissionController.fullname" .) }} {{- end }} webhooks: - name: vpa.k8s.io From 88e9156c73c44d2a2e4a4b9feed21b7a65a505f3 Mon Sep 17 00:00:00 2001 From: Paul Farver Date: Wed, 8 Jan 2025 19:55:11 +0100 Subject: [PATCH 2/2] Update charts/vertical-pod-autoscaler/CHANGELOG.md Co-authored-by: Steve Hipwell --- charts/vertical-pod-autoscaler/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/vertical-pod-autoscaler/CHANGELOG.md b/charts/vertical-pod-autoscaler/CHANGELOG.md index d4e642ee..5cea5ad7 100644 --- a/charts/vertical-pod-autoscaler/CHANGELOG.md +++ b/charts/vertical-pod-autoscaler/CHANGELOG.md @@ -16,7 +16,7 @@ ### Fixed -- Fixed incorrect cert-manager ca-injection target in mutatingwebhookconfiguration +- Fixed incorrect cert-manager ca-injection target in mutatingwebhookconfiguration. ([#1106](https://github.com/stevehipwell/helm-charts/pull/1106)) _@PaulFarver_ ## [v1.7.1] - 2024-08-22