Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSyData] Minor extraction library updates #2878

Open
4 tasks
hiker opened this issue Jan 30, 2025 · 0 comments
Open
4 tasks

[PSyData] Minor extraction library updates #2878

hiker opened this issue Jan 30, 2025 · 0 comments
Assignees
Labels
in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH PSyKE Related to the kernel extraction and driver creation PSyKE

Comments

@hiker
Copy link
Collaborator

hiker commented Jan 30, 2025

With the kernel extraction started to be used more (e.g. in NG-ARCH), I am in the process of integration this with our Baf build system (which is the lfric Fab build system). That will involve copying the PSyclone NetCDF LFRic extraction files into the build system (so they can be injected into the Fab build, so no need for creating libraries etc). A few changes required:

  • Minor updates to debug output (using trim to remove white spaces)
  • LFRic's real field types have been renamed (field_r{{prec}}_mod to field_real{{prec}}_mod etc). We can't simply switch this, since atm our infrastructure is outdated (see LFRic changed name of field_r*types #2623 for details, and also PSyclone is now unfriendly to case-insensitive filesystems #2239 - best solution is to switch to the now stand-alone lfric infrastructure files, which should support non-MPI builds now). As a quick solution till this is properly fixed, I'll add a second copy of the jinja files with the new names.
  • The count of errors is not correct, the compare library should be using (I think)
      all_results(current_index, COUNT_NEG_3) = COUNT(tmp > 1.0D-3)
      all_results(current_index, COUNT_NEG_6) = COUNT(tmp > 1.0D-6) - all_results(current_Index, COUNT_NEG_3)
      all_results(current_index, COUNT_NEG_9) = COUNT(tmp > 1.0D-9) - all_results(current_Index, COUNT_NEG_6) &
                                                                    - all_results(current_Index, COUNT_NEG_3)
  • We should also include the overall number of elements (and/or the number of elements >1.0d-3 error)
@hiker hiker added in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH PSyData labels Jan 30, 2025
@hiker hiker self-assigned this Jan 30, 2025
hiker added a commit that referenced this issue Feb 3, 2025
…ort the new names of the various lfric fields.
@hiker hiker added PSyKE Related to the kernel extraction and driver creation PSyKE and removed PSyData labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress NG-ARCH Issues relevant to the GPU parallelisation of LFRic and other models expected to be used in NG-ARCH PSyKE Related to the kernel extraction and driver creation PSyKE
Projects
None yet
Development

No branches or pull requests

1 participant