(JSONArray).toList() breaks format of entries

[JulWas797]

Unfortunately invoking method .toList() on JSONArray Object causes entries of the JSONArray to become malformated.

Issue examples:

Output from (JSONArray).get()
{"data":{"pressure_avg":1012.3399999999999,"humidity_avg":61.5,"temperature_avg":12.85,"pm10_avg":0.6900000000000001,"pm25_avg":0.36},"school":{"city":"DŁUGOŁĘKA","street":null,"post_code":"19-111","latitude":"53.2753471","name":"SZKOŁA PODSTAWOWA W DŁUGOŁĘCE","longitude":"22.8683732"},"timestamp":"2023-05-19 23:56:45"}

Output from (JSONArray).toList().get()
{data={pressure_avg=1012.3399999999999, humidity_avg=61.5, temperature_avg=12.85, pm10_avg=0.6900000000000001, pm25_avg=0.36}, school={city=DŁUGOŁĘKA, street=null, post_code=19-111, latitude=53.2753471, name=SZKOŁA PODSTAWOWA W DŁUGOŁĘCE, longitude=22.8683732}, timestamp=2023-05-19 23:56:45}

[JulWas797]

I decided to change the title, as it's late for me and i made mistake in it.

According to your javadocs, this is not a desired behavior.

[stleary]

@JulWas797 JSONArray.toString() will output a JSON doc, if that is what you want. We cannot change toList() due to backwards compatibility. Can you describe what you are trying to do?

[JulWas797]

@JulWas797 JSONArray.toString() will output a JSON doc, if that is what you want. We cannot change toList() due to backwards compatibility. Can you describe what you are trying to do?

Thanks for responding!

What I'm trying to basically acheive is to access elements of JSONArray using Streams API, and using .toList() is the only option to do so.

As JSONArray already has Iterator, i would propose to integrate Streams directly in it (I will also check what I can do, and maybe try to make PR with this).

[stleary]

Streams support proposed implementation: #768

[Aryant-Tripathi]

Sir @stleary , What will be the expected result we want? I just started putting my steps in the open-source community. I will be glad if I can help :)

[ZachsCoffee]

@stleary
I can propose a solution for this: I can make the org.json.JSONArray to implement the java.util.List interface and not the Iterable directly. This way, it will have the stream() method also all the functionality that a List should have. Because as I see from the class code it behaves like a List but with some minor changes.
(I have these changes ready for PR)

[Priyanshu-ai902]

Hi @stleary i am interested in this issue
Will you assign me this issue to work on it