Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] OnBeforeRender option has no effect whatsoever on Angular Storybook #164

Open
Tim-arts opened this issue Oct 18, 2021 · 0 comments
Open
Labels

Comments

@Tim-arts
Copy link

Tim-arts commented Oct 18, 2021

Describe the bug

As indicated in the documentation, users could change the render of the domString following this way:

export default {
  title: 'Components/TestComponent',
  parameters: {
    jsx: {
      onBeforeRender: (domString: string) => {
        console.log(domString)
        return domString;
      }
    }
  }
};

However, the control seems to be absent as I have no logs into console. As a reproduction, I'm running a Storybook Angular which connects the JSX addon, so you could simply get a fresh install, install the addon and try to change the onBeforeRender behavior.

I've also tried to make the change globally into the preview.js, but it's still the same

Update: I've created two new fresh SB projects, one Angular and one React and seems the issue is only present for the Angular one

@Tim-arts Tim-arts added the bug label Oct 18, 2021
@Tim-arts Tim-arts changed the title [Bug] [Bug] OnBeforeRender has no effect whatsoever Oct 18, 2021
@Tim-arts Tim-arts changed the title [Bug] OnBeforeRender has no effect whatsoever [Bug] OnBeforeRender option has no effect whatsoever Oct 18, 2021
@Tim-arts Tim-arts changed the title [Bug] OnBeforeRender option has no effect whatsoever [Bug] OnBeforeRender option has no effect whatsoever on Angular Storybook Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant