Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

UI: Fix z-index in modal elements #78

Merged
merged 3 commits into from
Dec 27, 2023
Merged

UI: Fix z-index in modal elements #78

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a21205b
fix z-index in modal elements
cdedreuille Sep 26, 2023
623d2b2
update step selector
yannbf Sep 26, 2023
9bdace7
Revert "update step selector"
yannbf Dec 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/Modal/Modal.styled.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ export const StyledOverlay = styled.div`
inset: 0px;
width: 100%;
height: 100%;
z-index: 10;
`;

export const StyledContent = styled.div<{
Expand All @@ -27,6 +28,7 @@ export const StyledContent = styled.div<{
max-width: calc(100% - 40px);
max-height: 85vh;
overflow: hidden;
z-index: 11;

&:focus-visible {
outline: none;
Expand Down
2 changes: 1 addition & 1 deletion src/features/GuidedTour/GuidedTour.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ export function GuidedTour({
},
},
{
target: "#root div[role=main]",
target: "#root > div",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work for Storybook 7 and 8. The elements structure changed and there's no role=main anymore. This needs to be tweaked and tested in both Storybook 7 and 8 (via a canary release)

title: "Interactive story playground",
content: (
<>
Expand Down
Loading