From c9068351d3eb003edd2f7d3814a93ab6e80ffbdf Mon Sep 17 00:00:00 2001 From: Michael Shilman Date: Thu, 21 Dec 2023 00:24:12 +0800 Subject: [PATCH] CLI: Never prompt for ESLint plugin --- code/lib/cli/src/generators/baseGenerator.ts | 21 ++++---------------- 1 file changed, 4 insertions(+), 17 deletions(-) diff --git a/code/lib/cli/src/generators/baseGenerator.ts b/code/lib/cli/src/generators/baseGenerator.ts index 70daf5764dd..5ad50927d01 100644 --- a/code/lib/cli/src/generators/baseGenerator.ts +++ b/code/lib/cli/src/generators/baseGenerator.ts @@ -13,11 +13,7 @@ import { getPackageDetails } from '../js-package-manager'; import { getBabelPresets, writeBabelConfigFile } from '../babel-config'; import packageVersions from '../versions'; import type { FrameworkOptions, GeneratorOptions } from './types'; -import { - configureEslintPlugin, - extractEslintInfo, - suggestESLintPlugin, -} from '../automigrate/helpers/eslintPlugin'; +import { configureEslintPlugin, extractEslintInfo } from '../automigrate/helpers/eslintPlugin'; import { detectBuilder } from '../detect'; const logger = console; @@ -177,14 +173,7 @@ const hasFrameworkTemplates = (framework?: SupportedFrameworks) => export async function baseGenerator( packageManager: JsPackageManager, npmOptions: NpmOptions, - { - language, - builder, - pnp, - frameworkPreviewParts, - yes: skipPrompts, - projectType, - }: GeneratorOptions, + { language, builder, pnp, frameworkPreviewParts, projectType }: GeneratorOptions, renderer: SupportedRenderers, options: FrameworkOptions = defaultOptions, framework?: SupportedFrameworks @@ -362,10 +351,8 @@ export async function baseGenerator( ); if (hasEslint && !isStorybookPluginInstalled) { - if (skipPrompts || (await suggestESLintPlugin())) { - depsToInstall.push('eslint-plugin-storybook'); - await configureEslintPlugin(eslintConfigFile ?? undefined, packageManager); - } + depsToInstall.push('eslint-plugin-storybook'); + await configureEslintPlugin(eslintConfigFile ?? undefined, packageManager); } } } catch (err) {