Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: better ux when autosave is off (#6610) #6849

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

web: better ux when autosave is off (#6610) #6849

wants to merge 8 commits into from

Conversation

01zulfi
Copy link
Collaborator

@01zulfi 01zulfi commented Nov 8, 2024 •
edited
Loading

Signed-off-by: 01zulfi [email protected]

Closes #6610

@01zulfi 01zulfi force-pushed the feat/autosave-off-ux branch 3 times, most recently from 45f2732 to 447a1be Compare November 11, 2024 10:13
@01zulfi 01zulfi changed the title web: (wip) better ux when autosave is off web: better ux when autosave is off (#6610) Nov 11, 2024
@01zulfi 01zulfi marked this pull request as ready for review November 11, 2024 10:14
thecodrr
thecodrr requested changes Nov 16, 2024
View reviewed changes
apps/web/src/components/editor/tiptap.tsx Outdated Show resolved Hide resolved
apps/web/src/components/editor/manager.ts Outdated Show resolved Hide resolved
apps/web/src/stores/editor-store.ts Outdated Show resolved Hide resolved
@01zulfi 01zulfi force-pushed the feat/autosave-off-ux branch 2 times, most recently from 8eafc4b to 125718b Compare November 18, 2024 07:38
thecodrr
thecodrr approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@thecodrr thecodrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will do some testing on this.

thecodrr
thecodrr requested changes Nov 18, 2024
View reviewed changes
apps/web/src/components/editor/index.tsx Show resolved Hide resolved
apps/web/src/components/editor/action-bar.tsx Outdated Show resolved Hide resolved
apps/web/src/stores/editor-store.ts Show resolved Hide resolved
@thecodrr
Copy link
Contributor

Since we are doing this, let's also add the following tests:

  • Auto save should turn off after user crosses 100K words
  • Ctrl + S should trigger save
  • Switching notes should trigger save
  • Creating a new note should trigger save
  • Closing the note should trigger save

And any other conditions that we can test for.

thecodrr
thecodrr requested changes Nov 25, 2024
View reviewed changes
apps/web/__e2e__/editor.test.ts Outdated Show resolved Hide resolved
apps/web/__e2e__/editor.test.ts Outdated Show resolved Hide resolved
apps/web/__e2e__/editor.test.ts Outdated Show resolved Hide resolved
apps/web/__e2e__/editor.test.ts Show resolved Hide resolved
apps/web/__e2e__/notes.test.ts Outdated Show resolved Hide resolved
apps/web/__e2e__/notes.test.ts Outdated Show resolved Hide resolved
apps/web/__e2e__/notes.test.ts Outdated Show resolved Hide resolved
apps/web/src/components/editor/action-bar.tsx Outdated Show resolved Hide resolved
apps/web/src/components/editor/action-bar.tsx Outdated Show resolved Hide resolved
apps/web/src/components/editor/tiptap.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecodrr thecodrr Awaiting requested review from thecodrr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lost work because autosave is off
2 participants
@01zulfi @thecodrr