Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Add global styles variables in relevant places #309

Open
johnstonphilip opened this issue Feb 17, 2020 · 1 comment
Open

Add global styles variables in relevant places #309

johnstonphilip opened this issue Feb 17, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@johnstonphilip
Copy link
Collaborator

With global styles coming to WP Core, we'll likely want to consider adding the global styles variables to Atomic Blocks. Here's an example of that happening for core blocks:

https://github.com/WordPress/gutenberg/pull/20273/files

I'm not sure if this is the right time to start work on this yet, but I just wanted to get it logged for consideration!

@mindctrl mindctrl added the enhancement New feature or request label Feb 17, 2020
@nickcernis
Copy link
Collaborator

Noting that the Global Styles proposal does not yet provide a way for Atomic Blocks to add its own variables to the global styles tree. (AB could use WP core style variables, but not add its own.)

I made a proposal with that in mind: WordPress/gutenberg#20449

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants