Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

Preview of block width seems unnecessarily off #359

Open
jonschr opened this issue Apr 20, 2020 · 3 comments
Open

Preview of block width seems unnecessarily off #359

jonschr opened this issue Apr 20, 2020 · 3 comments

Comments

@jonschr
Copy link

jonschr commented Apr 20, 2020

Describe the bug
There's a 58-pixel padding on editor areas inside fullwidth containers. That seems unnecessary at first glance, and makes for a worse user experience previewing what their content will look like.

To Reproduce
Video: https://www.loom.com/share/a32d505a99c844ea9eb300ea530855c8

Expected behavior
No padding added unless absolutely necessary, since that padding diverges from the near-pixel-perfect preview.

Screenshots
If applicable, add screenshots to help explain your problem.

Version

  • 2.8.0

Device and browser information

  • OS: Mac
  • Browser Chrome
  • Version 80.0.x
@mikemcalister
Copy link
Contributor

Thanks for this, Jon. We've got a fix in place for this and will be rolling it out to the repo shortly.

@mikemcalister
Copy link
Contributor

mikemcalister commented Apr 20, 2020

I should clarify, we're going to keep the padding on the outermost container, because that brings the block moving toggles back into the viewable area. But the padding won't cascade into nested blocks. Hopefully we can remove this soon when those toggles are moved away from the left side of the blocks permanently. Right now, you can use the top bar mode to alleviate that, but while it's optional, we'll have to keep something in there to account for the full width. Core columns do something similar.

toggles

@jonschr
Copy link
Author

jonschr commented Apr 21, 2020

Awesome, sounds good, Mike. You'll know better than me, with a more holistic view of what's going on, what's doable and what's necessary – I think just eliminating the cascading should be quite helpful. I didn't show it in the video, but this bug is most pronounced when using a columns block or ab columns block within a container, so eliminating the nesting will certainly resolve that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants