Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Genesis Connect notices dismissible #43

Open
nickcernis opened this issue Nov 21, 2018 · 4 comments
Open

Make Genesis Connect notices dismissible #43

nickcernis opened this issue Nov 21, 2018 · 4 comments

Comments

@nickcernis
Copy link
Contributor

Gutenberg 4.3 / WP 5.0 Beta 5 now makes admin notices display in the new editor. As our notice is not dismissible, it covers the editor, forcing people to deactivate the plugin.

We should consider making the notice dismissible, or explore ways to show it only on non-editor pages.

edit_post_ _wp_beta_ _wordpress
@dreamwhisper
Copy link
Contributor

Ref: WordPress/gutenberg#12243

@nickcernis
Copy link
Contributor Author

An issue is now raised for this in Trac, and scheduled for WP 5.0: https://core.trac.wordpress.org/ticket/45405

Depending on the results there we may not need to take further action here.

@nickcernis
Copy link
Contributor Author

Looks like this will be fixed in WordPress/gutenberg#12301 for Gutenberg 4.7.

@nickcernis
Copy link
Contributor Author

The admin notices component appears to have been removed: WordPress/gutenberg#12444

Need to retest in the final RC/release version, but it's likely that fix will resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickcernis @dreamwhisper