-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow toolbar to be displayed at the top of the editable area #5
Comments
Can you describe the situations where the overlay (dynamic positioning) makes problems? Maybe we can do improvements there instead. I see several issues with a fixed toolbar:
I think one fixed toolbar works well for editor 'apps' when they are always visible outside of the scrollable editing area (cmp. Word, Google Docs, Texture). However for our light-weight Forms use-case, I think the contextual toolbar is the better option. |
@michael I understand your points about using a fixed toolbar. I think perhaps the concerns could be solved in other ways. We found 2 specific situations where the current toolbar was either problematic or confusing for a user:
The 1st item is not necessarily an issue with the toolbar position. It is more of an issue with timing and when the toolbar becomes available. Perhaps if it were available on focus it would allow the user to select styling and then enter text. The 2nd issue could perhaps simply be resolved by hiding the toolbar when the comment button is clicked. |
Thanks for writing that up! Regarding 1) With Substance we went for 'semantic' annotations, which means you write first, then you tag certain things (strong, link, etc.). We had requests from other users to use a classic paint-mode for style annotations (turn emphasis on, then start typing). There are some technical difficulties with this but we may add this at some point. However, I think this paint-mode only works well with fixed toolbars. When using an overlay, we don't want to show the tools on a collapsed cursor (that would be too noisy). The current behaviour is consistent with other editors that use overlays (e.g. Medium.com). Tools appear contextually when you select text. Regarding 2) We can solve that by moving the focus to the comment field. Will work on that. |
We have a need to place the toolbar at the top of the textarea rather than in a dynamic position close to the user's selection. I think this would be valuable to provide as an option to the div element to allow users to choose the location of the toolbar.
For example:
The text was updated successfully, but these errors were encountered: