From a9b3a8d0fda36f0a3dc7fae05fa1c7975fadd268 Mon Sep 17 00:00:00 2001
From: Jesus Camacho Rodriguez <jesusca@microsoft.com>
Date: Wed, 29 Jan 2025 17:07:30 -0800
Subject: [PATCH] addressing comments

---
 proto/substrait/plan.proto | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/proto/substrait/plan.proto b/proto/substrait/plan.proto
index a236d836e..555344dde 100644
--- a/proto/substrait/plan.proto
+++ b/proto/substrait/plan.proto
@@ -48,8 +48,9 @@ message Plan {
   repeated string expected_type_urls = 5;
 
   // An optional list of bindings for dynamic parameters used in this plan.
-  // Each binding maps a parameter_anchor to its corresponding runtime value.
-  repeated ParameterBinding parameter_bindings = 7;
+  // The index of each entry in the list corresponds to the parameter_anchor
+  // of a DynamicParameter expression, mapping it to its runtime value.
+  repeated Expression.Literal parameter_bindings = 7;
 }
 
 // This message type can be used to deserialize only the version of a Substrait
@@ -84,12 +85,3 @@ message Version {
   // created the plan.
   string producer = 5;
 }
-
-// Represents a binding for a dynamic parameter.
-message ParameterBinding {
-  // The parameter anchor that identifies the dynamic parameter reference.
-  uint32 parameter_anchor = 1;
-
-  // The literal value assigned to the parameter at runtime.
-  Expression.Literal value = 2;
-}