Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayAnimatorWCS appears to be overriding user input slider labels #7

Open
DanRyanIrish opened this issue Mar 25, 2022 · 0 comments
Open
Labels
help wanted Extra attention is needed

Comments

@DanRyanIrish
Copy link
Member

Describe the bug

ArrayAnimatorWCS appears from the code to be overriding user input slider_labels: https://github.com/sunpy/mpl-animators/blob/main/mpl_animators/wcs.py#L103

Suggest the following replacement to the above line:

slider_labels = kwargs.pop("slider_labels", None)
if not slider_labers:
    slider_labels = self._compute_slider_labels_from_wcs(slices) + extra_slider_labels

To Reproduce

import sunpy

sunpy.map.Map(...)
etc

What happened?

No response

Expected behavior

No response

Screenshots

No response

System Details

No response

Installation method

No response

@Cadair Cadair added bug help wanted Extra attention is needed labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants