-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker socket mount path to config.toml #3127
Comments
A friend of mine is open to adding this change in (PR) as we already have done this in a fork if people are interested. |
Does it work today if you set the
I suspect a non-root socket is not trivial because we use dind for some containers, including analytics. But happy to review the change if you open a PR. |
We tested a bunch of things yesterday, and even though we didn't have much time to look into the code deeply, we believe there is a mistake in how it is being parsed. I'm not a go expert myself, but currently, the behaviour is that even though my shell's This is also the case if I run I'm 99% sure the wanted behaviour is to just strip out the |
FWIW things seem to be working for me w/ rootless Podman exposing a Docker-compatible socket if I disable analytics, so I think the issues are specific to that. |
And why do you think it works if you disable analytics? @eaceaser
Should be pretty self-explanatory. Adding more on your comment - yes, you are right about the cli successfully starting up the services if you disable the analytics service. But this should NOT be the intended behaviour and we should aim to fix this instead of using workarounds. As for the pr, I'll try to work on it tomorrow and make a submission for review. Hopefully we can get this sorted out so it becomes useable in its intended behaviour. Thank you edit - grammar |
@Fractal-Tess vector doesn't start for me when I disabled analytics? are you sure that's not an old container that hasn't been cleaned up? Besides Vector, all containers / local behavior seem to be fine when using an alternative docker socket path as far as I can tell. IDK why you think I'm implying that this shouldn't be fixed, I was just offering a workaround when I ran into this today considering that others may find this issue. |
Can you confirm the vector service starts up for you when you disable analytics and run |
yes:
edit: to be clear, it does NOT start up when analytics is disabled, hence the workaround |
Hum... yeah you are right. This is on me. I swear to god that there was a vector service in an error exit state when I tested earlier - must have not cleaned up properly before testing - good catch! Still, I believe this to be the cause of the docker socket, since after fixing this in the code and mounting the correct path, even with analytics and vector, it runs perfectly as intended. |
I've submitted a PR with the fixes that made my system work without a problem. Hopefully, this works on all unix-like machines, but I'm not certain. I haven't introduced an option for adding the Anyway, let me know what you think @sweatybridge. Thank you for your time. |
@Fractal-Tess thanks for the fix; I can confirm having Regarding the |
Is your feature request related to a problem? Please describe.
The problem is that on rootless docker in Linux (In my case, I'm on nixos) the docker socket isn't in the default path of
/var/run/docker.sock
, but instead at/run/user/1000/docker.sock
.Describe the solution you'd like
Add an option to the config.toml file to be able to change the location of the mounted docker socket
Additional context
This concerns users on Linux running the supabase cli - since the vector service mounts the docker socket, it crashes when it's not able to.
I can probably name 4-5 issues + a bunch of discord issues regarding the issue of the vector service crashing because of the
permissions os 13 error
regarding this issue. A fix like the one above could potentially solve all of these.The text was updated successfully, but these errors were encountered: