Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in safari, not passing host fails the live reload of code #343

Closed
superandrew opened this issue Feb 27, 2021 · 2 comments
Closed

in safari, not passing host fails the live reload of code #343

superandrew opened this issue Feb 27, 2021 · 2 comments

Comments

@superandrew
Copy link

In the book the example with webpack-plugin-serve fails on Safari (Mac Os Big sure) unless host is specified:

module.exports = {
  watch: mode === "development",
  entry: ["./src", "webpack-plugin-serve/client"],
  mode,
  plugins: [
    new MiniHtmlWebpackPlugin({ context: { title: "Demo" } }),
    new WebpackPluginServe({
      port: process.env.PORT || 8080,
      static: "./dist",
      liveReload: true,
      waitForBuild: true,
      host: "127.0.0.1",
    }),
  ],
}

In chrome it works normally. It took some time to understand what was going wrong, so I hope this might help others.

@superandrew
Copy link
Author

I think it's related to #342 (not sure why it was closed by the OP)

@bebraw
Copy link
Member

bebraw commented Mar 1, 2021

Thanks! I've fixed this and I'll deploy the fix soon.

I opened a related issue at shellscape/webpack-plugin-serve#215 . Maybe you can comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants