Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test installation in CI #111

Open
gonuke opened this issue Aug 2, 2021 · 8 comments
Open

Test installation in CI #111

gonuke opened this issue Aug 2, 2021 · 8 comments

Comments

@gonuke
Copy link
Member

gonuke commented Aug 2, 2021

I wonder if it is possible to test the installation process in CI by installing the plugin on a fresh cubit install and running something in batch mode?

@shimwell
Copy link
Member

shimwell commented Aug 2, 2021

Perhaps testing via the Cubit python API could also work 🐍

I can make a test that combines few stp files to production a h5m file using the Cubit Python API and pytest if that helps

@shimwell
Copy link
Member

shimwell commented Aug 9, 2021

I'm thinking something like this can be added to the yml files

    steps:
      - name: install cubit
        shell: bash -l {0}
        run: |
          apt-get install -y curl
          dpkg -i ${CUBIT_PKG}

          tar -xzvf svalinn-plugin_${{ matrix.os }}-${{ matrix.os_version }}_cubit_${{ matrix.cubit }}.tgz -C /opt/${CUBIT_BASE_NAME}

      - name: test cubit use with python
          pip install pytest
          # py script accesses CUBIT_BASE_NAME and imports Cubit into the system python
          # then imprints, merges and facetets two stp files and outputs a h5m file
          pytest tests/test_stp_file_conversion_to_h5m.py

@bam241
Copy link
Member

bam241 commented Aug 10, 2021

do you need a cubit license to run this ?

@shimwell
Copy link
Member

I think we fall into the non commercial use for students, hobbyists, researchers as mentioned described on the cubit-learn product page https://coreform.com/products/coreform-cubit/free-meshing-software/

Perhaps good to double check with Coreform

@GregVernon are we ok to make use of Cubit learn in the CI testing of the DAGMC plugin for Cubit learn?

@GregVernon
Copy link

@shimwell - you're okay to use Coreform Cubit Learn as you've described. Thanks for checking!

@shimwell
Copy link
Member

Just tinkering around with a docker file that downloads Cubit from where it is hosted (backblaze) and installing the plugin within a few environments. I noticed the download takes 15mins from here.

While this is not much time it will be the longest stage in the building of our docker images. We currently have 6 Docker based builds. So we would be downloading this 6 * 15 mins with the simplest setup.

We might benefit from a single download and volume mounting to the docker files which would be a more efficient but trickier CI script to create.

@shimwell
Copy link
Member

Just stumbled along a not batch compatible aspect of importing Cubit via python and raised it on the Cubit forum https://forum.coreform.com/t/automatically-accepting-the-license-agreement-y-n/1208

@shimwell
Copy link
Member

Thanks @GregVernon for

Just stumbled along a not batch compatible aspect of importing Cubit via python and raised it on the Cubit forum https://forum.coreform.com/t/automatically-accepting-the-license-agreement-y-n/1208

This has now be solved by Greg on the forum.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants