Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Kafka job queue implementation #11

Open
svaloumas opened this issue Aug 20, 2022 · 0 comments
Open

feat: add Kafka job queue implementation #11

svaloumas opened this issue Aug 20, 2022 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up for grabs

Comments

@svaloumas
Copy link
Owner

svaloumas commented Aug 20, 2022

Is your feature request related to a problem? Please describe.
Currently, there are three concrete implementations of the JobQueue interface (in-memory, RabbitMQ, and Redis).

Describe the solution you'd like
It would be nice to extend this flexibility by adding a Kafka FIFO job queue implementation.

Additional context
The interface to be implemented is the following.

// JobQueue represents a driven actor queue interface.
type JobQueue interface {
	// Push adds a job to the queue.
	Push(j *domain.Job) error

	// Pop removes and returns the head job from the queue.
	Pop() *domain.Job

	// CheckHealth checks if the job queue is alive.
	CheckHealth() bool

	// Close liberates the bound resources of the job queue.
	Close()
}

The config and the job queue factory method should also be updated to support the new functionality.
README should also be updated accordingly.

@svaloumas svaloumas added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers documentation Improvements or additions to documentation up for grabs labels Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed up for grabs
Projects
None yet
Development

No branches or pull requests

1 participant