Skip to content

feat: return meaningful status codes #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SilasPeters opened this issue Apr 12, 2025 · 0 comments
Open

feat: return meaningful status codes #15

SilasPeters opened this issue Apr 12, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@SilasPeters
Copy link
Member

Currently, when a webhook is called to run a systemd service, you simply get an HTTP 200 when the service has been started.

This issue suggests we optionally (as defined in the config) await the exit code of the service, and return a 200 or 500 depending on the exit code.
An example of why this is useful, is for github workflows. A workflow will await full deployment and can test it afterwards. If deployment failed, the workflow fails. If the workflow completed succesfully, you can expect to immediatly see the results. Full deployment experience!

@SilasPeters SilasPeters added the enhancement New feature or request label Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant