Skip to content

Commit

Permalink
Allow passing --breakage-allowlist-path to the API breakage check
Browse files Browse the repository at this point in the history
  • Loading branch information
ahoppen committed Nov 15, 2024
1 parent 3fca720 commit 19cb62c
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion .github/workflows/soundness.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ on:
type: boolean
description: "Boolean to enable the API breakage check job. Defaults to true."
default: true
api_breakage_check_allowlist_path:
type: string
description: "Path to a file that will be passed as --breakage-allowlist-path to swift package diagnose-api-breaking-changes"
default: ""
api_breakage_check_container_image:
type: string
description: "Container image for the API breakage check job. Defaults to latest Swift Ubuntu image."
Expand Down Expand Up @@ -89,7 +93,11 @@ jobs:
- name: Run API breakage check
run: |
git fetch ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} ${GITHUB_BASE_REF}:pull-base-ref
swift package diagnose-api-breaking-changes pull-base-ref
if [[ -z '${{ inputs.api_breakage_check_allowlist_path }}' ]]; then
swift package diagnose-api-breaking-changes pull-base-ref
else
swift package diagnose-api-breaking-changes pull-base-ref --breakage-allowlist-path '${{ inputs.api_breakage_check_allowlist_path }}'
fi
docs-check:
name: Documentation check
Expand Down Expand Up @@ -217,6 +225,7 @@ jobs:
curl -s https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/configs/yamllint.yml > .yamllint.yml
fi
yamllint --strict --config-file .yamllint.yml .
python-lint-check:
name: Python lint check
if: ${{ inputs.python_lint_check_enabled }}
Expand Down

0 comments on commit 19cb62c

Please sign in to comment.