Toolchain build output regression: this repo no longer dumps much build info as part of the Swift toolchain build #8281
Assignees
Labels
bootstrap
Bootstrapping script & swift-bootstrap
continuous integration/deployment
Changes to the Continuous Integration/Deployment system/pipelines
Comments
finagolfin
added
bootstrap
So when the
Prior to #8161, the flag only emitted additional messages when set. This behaviour has been preserved when the conversion from I applied the following patch and ran without with Notice that with |
Yes, unfortunately, your change did more than just add some logging, it also got the
Sure, compare that minimal build output from building SwiftPM in the
No, the
Yes, I saw that you add some extra debug logging calls, and that that works fine. I'm not talking about that. I'm talking about swallowing up SwiftPM build output after your logging changes. If you doubt anything I'm saying, try it for yourself: revert the I don't much care about 1. in my OP, but your pull breaking 2., ie |
|
Maybe I was not clear, but I don't doubt an issue exists :). I was just trying to get clarity as to what has changed. I understand this is an issue, and it needs to be rectified, but I don't understand how the original PR (#8161) could impact this as it does not make any changes to the actual Maybe that is the cause of the missing output, but that would not explain why the Looking at #8161, I do see some instances where the subprocess call were "modified"
I'll try to have a look asap. |
|
Thanks, I try to avoid Python so I was hoping you'd have a better idea. If you cannot find what changed to cause this, maybe someone else will chime in. |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this issue
Feb 7, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
|
@finagolfin : Could you please give #8285 a try to see if it provides additional output - my testing revealed it did, but it would be great getting confirmation. |
|
Nothing for me to try, the linux CI shows you what it outputs now: That SwiftPM output after the |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this issue
Feb 10, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this issue
Feb 11, 2025
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A recent pull turned on some logging info in the Python
Utilities/bootstrapscript, #8161, but unfortunately that had other consequences:-vflag when passed to thebootstrapscript no longer does muchI had noticed 1. for awhile, but 2. particularly hit me now when passing in
-vmanually to try and debug an Android build failure I'm seeing. I ended up reverting the changes from that pull to thebootstrapscript locally to get the proper verbose build output again.@bkhouri, you made that logging change, do you happen to know how to fix this too?
The text was updated successfully, but these errors were encountered: