SILGen: adjust check for optional-to-optional conversion

The new macro aliasing uncovered a latent issue where we would attempt
to perform an optional-to-optional conversion on a type that is
non-optional though may be aliased to an optional. `CVaList` is
sometimes an optional pointer and would be interpreted as an optional
type which would fail the assertion in the optional-to-optional
conversion.

Author: compnerd

lib/SILGen/SILGenPoly.cpp

@@ -509,7 +509,8 @@ ManagedValue Transform::transform(ManagedValue v,
   bool inputIsOptional = (bool) inputObjectType;
 
   CanType outputObjectType = outputSubstType.getOptionalObjectType();
-  bool outputIsOptional = (bool) outputObjectType;
+  bool outputIsOptional =
+      static_cast<bool>(loweredResultTy.getASTType().getOptionalObjectType());
 
   // If the value is less optional than the desired formal type, wrap in
   // an optional.

test/SILGen/Inputs/module.modulemap

@@ -1,3 +1,7 @@
 module PointerAuth {
-   header "ptrauth_field_fptr_import.h"
- }
+  header "ptrauth_field_fptr_import.h"
+}
+
+module Variadic {
+  header "variadic.h"
+}

test/SILGen/Inputs/variadic.h

@@ -0,0 +1,6 @@
+#pragma once
+
+#include <stdarg.h>
+
+#define u_vformatMessage swift_u_vformatMessage
+void u_vformatMessage(int i, va_list ap);

test/SILGen/variadic.swift

@@ -0,0 +1,20 @@
+// RUN: %swift_frontend_plain -S -emit-silgen %s -I %S/Inputs -o - -parse-as-library | %FileCheck %s
+
+import Variadic
+
+public func f() {
+  withVaList([0.0]) {
+    u_vformatMessage(0, $0)
+  }
+}
+
+// CHECK: bb0(%0 : $*(), %1 : $CVaListPointer):
+// CHECK: %3 = function_ref @$sSC16u_vformatMessageyys5Int32V_s14CVaListPointerVSgtcvg : $@convention(thin) () -> @owned @callee_guaranteed (Int32, Optional<CVaListPointer>) -> ()
+// CHECK: %4 = apply %3() : $@convention(thin) () -> @owned @callee_guaranteed (Int32, Optional<CVaListPointer>) -> ()
+// CHECK: %5 = integer_literal $Builtin.IntLiteral, 0
+// CHECK: %6 = metatype $@thin Int32.Type
+// CHECK: %7 = function_ref @$ss5Int32V22_builtinIntegerLiteralABBI_tcfC : $@convention(method) (Builtin.IntLiteral, @thin Int32.Type) -> Int32
+// CHECK: %8 = apply %7(%5, %6) : $@convention(method) (Builtin.IntLiteral, @thin Int32.Type) -> Int32
+// CHECK: %9 = enum $Optional<CVaListPointer>, #Optional.some!enumelt, %1
+// CHECK: %10 = begin_borrow %4
+// CHECK: %11 = apply %10(%8, %9) : $@callee_guaranteed (Int32, Optional<CVaListPointer>) -> ()