Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Membership check happens only once #96

Open
AnotherMatt92 opened this issue Aug 6, 2024 · 1 comment
Open

Membership check happens only once #96

AnotherMatt92 opened this issue Aug 6, 2024 · 1 comment

Comments

@AnotherMatt92
Copy link
Contributor

If a member leaves they get a member check email
If they join again and stop for a second time they do not get a new membercheck email
There is a flag or similar in the code to make sure this email is only sent once, but this should be reset if membership starts back up again
Does this affect any other emails sent too?

@AnotherMatt92
Copy link
Contributor Author

It appears that when the function send_reminder_email (lib/AccessSystem/API/Controller/Root.pm line 980) is checks all previous emails sent to the member to see if one is called 'reminder_email' if its there then it will never send an other one.

Is it possible that when we sent the rejoin_payment (lib/AccessSystem/Schema/Result/Person.pm line 540 that we remove the email name from emails set.

Or a better way might be to check if a rejoin_email has been sent more recently than the reminder_email - if so then its ok to send another reminder email as this is the second time (or more) that they have stopped their membership

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant