feat: add new radio text event #742
Merged
+530
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steinertech9
added
documentation
6 tasks
Steinertech9
force-pushed
the
dev/735-new-event-type-deardeventhubv1radiotext-for-possible-encoder-integration
branch
from
4259fd3 to
e19a1aa
Compare
|
Could you also add example messages from #735 like at https://swrlab.github.io/ard-eventhub/#/docs/TYPES (which we probably also link in https://swrlab.github.io/ard-eventhub/#/docs/EVENTS) |
frytg
reviewed
Jan 23, 2025
There was a problem hiding this comment.
and we should add a full POST example to the docs as @saerdnaer suggested (#742 (comment))
also, we could use 1.10.0 as version
| { | ||
| "event": "music", | ||
| "start": "2020-01-19T06:00:00+01:00", | ||
| "validUntil": "2026-01-19T06:00:00+01:00", |
There was a problem hiding this comment.
validUntil example should be greater than start?
There was a problem hiding this comment.
why not end or length – that would be more consistent with the existing event types, c.f. https://swrlab.github.io/ard-eventhub/#/docs/TYPES
…ext-for-possible-encoder-integration
frytg
approved these changes
Jan 29, 2025
frytg
deleted the
dev/735-new-event-type-deardeventhubv1radiotext-for-possible-encoder-integration
branch
|
Docker container is ready! VERSION: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new event for changing the live encoder for radio