Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff view in Workflow Actions tab can break for shortcodes #384

Open
robingram opened this issue Feb 7, 2019 · 1 comment
Open

Diff view in Workflow Actions tab can break for shortcodes #384

robingram opened this issue Feb 7, 2019 · 1 comment

Comments

@robingram
Copy link

When the workflow instance generates the diff of changed fields it will attempt to render HTML content, including shortcodes. This can break if the shortcode is rendered using a template that is in the themes folder because at the point that the diff is generated only the Admin themes are loaded.

A work-around for this is to put the shortcode templates into the app/templates folder but this might restrict the ability to use different templates in subsites.

@robbieaverill
Copy link
Contributor

We've worked around this in the past by temporarily setting frontend themes, rendering the template then restoring the themes config to what was there before - I think elemental area previews are an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants