Skip to content

Commit 230e15f

Browse files
rg911rg911
committed
Removed valueSize in Metadata model
1 parent 00a887e commit 230e15f

File tree

6 files changed

+9
-27
lines changed

6 files changed

+9
-27
lines changed

‎e2e/infrastructure/MetadataHttp.spec.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ describe('MetadataHttp', () => {
278278
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
279279
expect(metadata[0].metadataEntry.targetId).to.be.undefined;
280280
expect(metadata[0].metadataEntry.value).to.be.equal('Test account meta value');
281-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(23);
281+
expect(metadata[0].metadataEntry.value.length).to.be.equal(23);
282282
done();
283283
});
284284
});
@@ -294,7 +294,7 @@ describe('MetadataHttp', () => {
294294
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
295295
expect(metadata[0].metadataEntry.targetId).to.be.undefined;
296296
expect(metadata[0].metadataEntry.value).to.be.equal('Test account meta value');
297-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(23);
297+
expect(metadata[0].metadataEntry.value.length).to.be.equal(23);
298298
done();
299299
});
300300
});
@@ -309,7 +309,7 @@ describe('MetadataHttp', () => {
309309
expect(metadata.metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
310310
expect(metadata.metadataEntry.targetId).to.be.undefined;
311311
expect(metadata.metadataEntry.value).to.be.equal('Test account meta value');
312-
expect(metadata.metadataEntry.valueSize).to.be.equal(23);
312+
expect(metadata.metadataEntry.value.length).to.be.equal(23);
313313
done();
314314
});
315315
});
@@ -325,7 +325,7 @@ describe('MetadataHttp', () => {
325325
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
326326
expect((metadata[0].metadataEntry.targetId as MosaicId).toHex()).to.be.equal(mosaicId.toHex());
327327
expect(metadata[0].metadataEntry.value).to.be.equal('Test mosaic meta value');
328-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(22);
328+
expect(metadata[0].metadataEntry.value.length).to.be.equal(22);
329329
done();
330330
});
331331
});
@@ -341,7 +341,7 @@ describe('MetadataHttp', () => {
341341
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
342342
expect((metadata[0].metadataEntry.targetId as MosaicId).toHex()).to.be.equal(mosaicId.toHex());
343343
expect(metadata[0].metadataEntry.value).to.be.equal('Test mosaic meta value');
344-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(22);
344+
expect(metadata[0].metadataEntry.value.length).to.be.equal(22);
345345
done();
346346
});
347347
});
@@ -356,7 +356,7 @@ describe('MetadataHttp', () => {
356356
expect(metadata.metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
357357
expect((metadata.metadataEntry.targetId as MosaicId).toHex()).to.be.equal(mosaicId.toHex());
358358
expect(metadata.metadataEntry.value).to.be.equal('Test mosaic meta value');
359-
expect(metadata.metadataEntry.valueSize).to.be.equal(22);
359+
expect(metadata.metadataEntry.value.length).to.be.equal(22);
360360
done();
361361
});
362362
});
@@ -372,7 +372,7 @@ describe('MetadataHttp', () => {
372372
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
373373
expect((metadata[0].metadataEntry.targetId as NamespaceId).toHex()).to.be.equal(namespaceId.toHex());
374374
expect(metadata[0].metadataEntry.value).to.be.equal('Test namespace meta value');
375-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(25);
375+
expect(metadata[0].metadataEntry.value.length).to.be.equal(25);
376376
done();
377377
});
378378
});
@@ -388,7 +388,7 @@ describe('MetadataHttp', () => {
388388
expect(metadata[0].metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
389389
expect((metadata[0].metadataEntry.targetId as NamespaceId).toHex()).to.be.equal(namespaceId.toHex());
390390
expect(metadata[0].metadataEntry.value).to.be.equal('Test namespace meta value');
391-
expect(metadata[0].metadataEntry.valueSize).to.be.equal(25);
391+
expect(metadata[0].metadataEntry.value.length).to.be.equal(25);
392392
done();
393393
});
394394
});
@@ -403,7 +403,7 @@ describe('MetadataHttp', () => {
403403
expect(metadata.metadataEntry.targetPublicKey).to.be.equal(account.publicKey);
404404
expect((metadata.metadataEntry.targetId as NamespaceId).toHex()).to.be.equal(namespaceId.toHex());
405405
expect(metadata.metadataEntry.value).to.be.equal('Test namespace meta value');
406-
expect(metadata.metadataEntry.valueSize).to.be.equal(25);
406+
expect(metadata.metadataEntry.value.length).to.be.equal(25);
407407
done();
408408
});
409409
});

‎src/infrastructure/MetadataHttp.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ export class MetadataHttp extends Http implements MetadataRepository {
231231
metadataEntry.targetPublicKey,
232232
UInt64.fromHex(metadataEntry.scopedMetadataKey),
233233
metadataEntry.metadataType.valueOf(),
234-
Convert.decodeHex(metadataEntry.value).length,
235234
Convert.decodeHex(metadataEntry.value),
236235
targetId,
237236
),

‎src/model/metadata/MetadataEntry.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ export class MetadataEntry {
3232
* @param {string} targetPublicKey - The metadata target public key
3333
* @param {UInt64} scopedMetadataKey - The key scoped to source, target and type
3434
* @param {MetadatType} metadataType - The metadata type (Account | Mosaic | Namespace)
35-
* @param {number} valueSize - The metadata value size
3635
* @param {string} value - The metadata value
3736
* @param {MosaicId | NamespaceId | undefined} targetId - The target mosaic or namespace identifier
3837
*/
@@ -57,10 +56,6 @@ export class MetadataEntry {
5756
* The metadata type
5857
*/
5958
public readonly metadataType: MetadataType,
60-
/**
61-
* The metadata value size
62-
*/
63-
public readonly valueSize: number,
6459
/**
6560
* The metadata value
6661
*/

‎test/model/metadata/Metadata.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ describe('Metadata', () => {
3737
scopedMetadataKey: '85BBEA6CC462B244',
3838
targetId: undefined,
3939
metadataType: 0,
40-
valueSize: 5,
4140
value: '12345',
4241
};
4342
const metadataDTO = {
@@ -55,7 +54,6 @@ describe('Metadata', () => {
5554
metadataDTO.metadataEntry.targetPublicKey,
5655
UInt64.fromHex(metadataDTO.metadataEntry.scopedMetadataKey),
5756
metadataDTO.metadataEntry.metadataType,
58-
metadataDTO.metadataEntry.valueSize,
5957
metadataDTO.metadataEntry.value,
6058
),
6159
);
@@ -67,7 +65,6 @@ describe('Metadata', () => {
6765
deepEqual(metadata.metadataEntry.scopedMetadataKey, UInt64.fromHex('85BBEA6CC462B244'));
6866
deepEqual(metadata.metadataEntry.targetId, undefined);
6967
deepEqual(metadata.metadataEntry.metadataType, MetadataType.Account);
70-
deepEqual(metadata.metadataEntry.valueSize, 5);
7168
deepEqual(metadata.metadataEntry.value, '12345');
7269
});
7370
});

‎test/model/metadata/MetadataEntry.spec.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ describe('MetadataEntry', () => {
3737
scopedMetadataKey: '85BBEA6CC462B244',
3838
targetId: undefined,
3939
metadataType: 0,
40-
valueSize: 5,
4140
value: '12345',
4241
};
4342

@@ -47,7 +46,6 @@ describe('MetadataEntry', () => {
4746
metadataEntryDTO.targetPublicKey,
4847
UInt64.fromHex(metadataEntryDTO.scopedMetadataKey),
4948
metadataEntryDTO.metadataType,
50-
metadataEntryDTO.valueSize,
5149
metadataEntryDTO.value,
5250
);
5351

@@ -57,7 +55,6 @@ describe('MetadataEntry', () => {
5755
deepEqual(metadata.scopedMetadataKey, UInt64.fromHex('85BBEA6CC462B244'));
5856
deepEqual(metadata.targetId, undefined);
5957
deepEqual(metadata.metadataType, MetadataType.Account);
60-
deepEqual(metadata.valueSize, 5);
6158
deepEqual(metadata.value, '12345');
6259
});
6360

@@ -79,7 +76,6 @@ describe('MetadataEntry', () => {
7976
metadataEntryDTO.targetPublicKey,
8077
UInt64.fromHex(metadataEntryDTO.scopedMetadataKey),
8178
metadataEntryDTO.metadataType,
82-
metadataEntryDTO.valueSize,
8379
metadataEntryDTO.value,
8480
new MosaicId(metadataEntryDTO.targetId),
8581
);
@@ -90,7 +86,6 @@ describe('MetadataEntry', () => {
9086
deepEqual(metadata.scopedMetadataKey, UInt64.fromHex('85BBEA6CC462B244'));
9187
deepEqual((metadata.targetId as MosaicId).toHex(), '85BBEA6CC462B244');
9288
deepEqual(metadata.metadataType, MetadataType.Mosaic);
93-
deepEqual(metadata.valueSize, 5);
9489
deepEqual(metadata.value, '12345');
9590
});
9691

@@ -102,7 +97,6 @@ describe('MetadataEntry', () => {
10297
scopedMetadataKey: '85BBEA6CC462B244',
10398
targetId: '85BBEA6CC462B244',
10499
metadataType: 2,
105-
valueSize: 5,
106100
value: '12345',
107101
};
108102

@@ -112,7 +106,6 @@ describe('MetadataEntry', () => {
112106
metadataEntryDTO.targetPublicKey,
113107
UInt64.fromHex(metadataEntryDTO.scopedMetadataKey),
114108
metadataEntryDTO.metadataType,
115-
metadataEntryDTO.valueSize,
116109
metadataEntryDTO.value,
117110
NamespaceId.createFromEncoded(metadataEntryDTO.targetId),
118111
);
@@ -123,7 +116,6 @@ describe('MetadataEntry', () => {
123116
deepEqual(metadata.scopedMetadataKey, UInt64.fromHex('85BBEA6CC462B244'));
124117
deepEqual((metadata.targetId as NamespaceId).toHex(), '85BBEA6CC462B244');
125118
deepEqual(metadata.metadataType, MetadataType.Namespace);
126-
deepEqual(metadata.valueSize, 5);
127119
deepEqual(metadata.value, '12345');
128120
});
129121
});

‎test/service/MetadataTransactionservice.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ describe('MetadataTransactionService', () => {
175175
account.publicKey,
176176
key,
177177
MetadataType.Account,
178-
4,
179178
value,
180179
targetId),
181180
);

0 commit comments

Comments
 (0)