Skip to content

Commit 8d22439

Browse files
derrabusnicolas-grekas
authored andcommitted
Fix skip condition for INTL
Signed-off-by: Alexander M. Turek <[email protected]>
1 parent bd53358 commit 8d22439

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Tests/AbstractAsciiTestCase.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ public function testCreateFromEmptyString()
3636

3737
/**
3838
* @dataProvider provideBytesAt
39-
*
40-
* @requires extension intl 66.2
4139
*/
4240
public function testBytesAt(array $expected, string $string, int $offset, int $form = null)
4341
{
42+
if (2 !== grapheme_strlen('च्छे') && 'नमस्ते' === $string) {
43+
$this->markTestSkipped('Skipping due to issue ICU-21661.');
44+
}
45+
4446
$instance = static::createFromString($string);
4547
$instance = $form ? $instance->normalize($form) : $instance;
4648

@@ -159,11 +161,13 @@ public static function provideWrap(): array
159161

160162
/**
161163
* @dataProvider provideLength
162-
*
163-
* @requires extension intl 66.2
164164
*/
165165
public function testLength(int $length, string $string)
166166
{
167+
if (2 !== grapheme_strlen('च्छे') && 'अनुच्छेद' === $string) {
168+
$this->markTestSkipped('Skipping due to issue ICU-21661.');
169+
}
170+
167171
$instance = static::createFromString($string);
168172

169173
$this->assertSame($length, $instance->length());

Tests/AbstractUnicodeTestCase.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,13 @@ public static function provideBytesAt(): array
5757

5858
/**
5959
* @dataProvider provideCodePointsAt
60-
*
61-
* @requires extension intl 66.2
6260
*/
6361
public function testCodePointsAt(array $expected, string $string, int $offset, int $form = null)
6462
{
63+
if (2 !== grapheme_strlen('च्छे') && 'नमस्ते' === $string) {
64+
$this->markTestSkipped('Skipping due to issue ICU-21661.');
65+
}
66+
6567
$instance = static::createFromString($string);
6668
$instance = $form ? $instance->normalize($form) : $instance;
6769

0 commit comments

Comments
 (0)