-
-
Notifications
You must be signed in to change notification settings - Fork 358
BatchActionController isn't passing default route attributes #1022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm, yeah, I see the problem. We can't just do a simple attribute merge in |
Indeed, that seems risky business. The best thing imo is to apply the |
Yeah, the defaults are there in the sub-request but so are a lot of other attributes (added by the subscriber). When merging, we do get the defaults but a bunch of others that break the request. |
Thank you for this issue. |
Could I get a reply or should I close this? |
Hey, I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen! |
Thank you for this issue. |
Friendly reminder that this issue exists. If I don't hear anything I'll close this. |
Hey, I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen! |
I have a similar problem, in my case the _route param get overwritten in the ->duplicate function call:
what i did is i added this to the subRequest Attributes: the original _route param which should be I can provide a PR if nobody sees a problem 😄 |
@arrabiata-asanz sure, I've lost the context a bit here but a PR would be great! |
Uh oh!
There was an error while loading. Please reload this page.
Let's say we register the
ux_live_component
routes as following:When the
\Symfony\UX\LiveComponent\Controller\BatchActionController::__invoke
is invoking sub requests, it sets the only certain attributes. So that for example the_loginRequired
and_routeScope
defaults are skipped. I want to create a PR to address this issue but not sure where to look. As the defaults are added to the routes at compile time and the batchAction is invoking the requests directly so that the route matching (and default attributes logic) is skipped.The text was updated successfully, but these errors were encountered: