Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disk_log.erl] multi_req/2 weird return value #4

Open
tank-bohr opened this issue Jul 19, 2019 · 1 comment
Open

[disk_log.erl] multi_req/2 weird return value #4

tank-bohr opened this issue Jul 19, 2019 · 1 comment

Comments

@tank-bohr
Copy link
Collaborator

tank-bohr commented Jul 19, 2019

https://github.com/erlang/otp/blob/34b56e8f566c6f1aa6023bb7b4096b8f2d709d9e/lib/kernel/src/disk_log.erl#L1876-L1884

Reply isn't accumulated in foldl. Thus ok is returned if there were any successful req

@5HT
Copy link
Member

5HT commented Jul 19, 2019

I would say more general: we need to ban recieve end constructions in anything but gen_server replacement. The disk_log as the core transactional chain for mnesia and other services could be replaced by more modern https://github.com/xio/replayq implementation or at least merged with some ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants