Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kratix add container should fail if people add multiple pipeline to delete step #27

Open
ChunyiLyu opened this issue Jul 12, 2024 · 2 comments

Comments

@ChunyiLyu
Copy link
Member

ChunyiLyu commented Jul 12, 2024

Context

We should stop people from adding multiple pipelines to promise delete and resource delete workflows. Kratix currently only supports multiple pipelines for the configure workflows.

Design

kratix add container resource/delete/pipeline2 ...
Error: multiple pipelines not allowed in delete workflows: found existing pipeline 'pipeline1'
@abangser
Copy link
Member

Do you think we should stop this, or should we be supporting multiple pipelines in a delete workflow? I am not sure if we have discussed the use case for multiple pipelines in delete and the viability of running them.

@richcooper95
Copy link
Member

At the moment, I think we should stop this ✋

We don't support it in Kratix (yet) and it's not come up as feedback. It'd take some work to implement multiple delete pipelines, so IMO it's better for the CLI to be consistent with the current state of Kratix, and change the CLI if/when we ever add the feature to Kratix!

@richcooper95 richcooper95 self-assigned this Oct 2, 2024
@ChunyiLyu ChunyiLyu self-assigned this Oct 2, 2024
@ChunyiLyu ChunyiLyu changed the title kratix cli add container should fail if people add multiple pipeline to delete step feat: kratix add container should fail if people add multiple pipeline to delete step Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants