You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently introduced filepath.mode=none in destinations, which stops kratix from nesting files into directories. However, Kratix will still create at least one directory, named after the destination metadata.name.
There's a good reason why it behaves this way: state stores can be shared across different destinations, and not having a unique top-level directory can lead to file clashes. On the other hand, it's a bit confusing for users to explicitly set it to none but still get "one".
A less surprising experience would be if filepath.mode=none didn't create any directories at all. Users can still create subdirs for the destination by setting the spec.path field. We could also make it configurable via another property.
Warning
Depending on the implementation decision, this may be a breaking change. Consider a migration webhook so it's not
Scenarios
# Migration for existing DestinatinosGiven a destination set to filepath.mode=none and path=subdir
When I upgrade Kratix to the latest version
Then the migration webhook updates my Destination
And the `spec.path` migrates from `subdir` to `<destination name>/subdir`
# Brand new destinationGiven a destination set to filepath.mode=none and path=nil
When a workplacement is created for that destination
Then it's written to the root directory
The text was updated successfully, but these errors were encountered:
We recently introduced
filepath.mode=none
in destinations, which stops kratix from nesting files into directories. However, Kratix will still create at least one directory, named after the destinationmetadata.name
.There's a good reason why it behaves this way: state stores can be shared across different destinations, and not having a unique top-level directory can lead to file clashes. On the other hand, it's a bit confusing for users to explicitly set it to
none
but still get "one".A less surprising experience would be if
filepath.mode=none
didn't create any directories at all. Users can still create subdirs for the destination by setting thespec.path
field. We could also make it configurable via another property.Warning
Depending on the implementation decision, this may be a breaking change. Consider a migration webhook so it's not
Scenarios
The text was updated successfully, but these errors were encountered: