Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect is not a early terminating method, but httpError is #28

Open
beerbohmdo opened this issue Mar 4, 2024 · 0 comments
Open

redirect is not a early terminating method, but httpError is #28

beerbohmdo opened this issue Mar 4, 2024 · 0 comments

Comments

@beerbohmdo
Copy link

beerbohmdo commented Mar 4, 2024 •
edited
Loading

In the phpstan.neon the redirect method is defined as a earlyTerminatingMethodCalls, but this method does not exit it returns a HTTPResponse.

(Yes the method has the side-effect, that is set the response object of the controller - but it does not early exits ...)

httpError which throws a HTTPResponse_Exception should be marked as earlyTerminating instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beerbohmdo