Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: when executing ssdev commands in subdirectories, there should be a warning when no project is present #16

Open
3 tasks
mleutenegger opened this issue Nov 18, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request priority: medium

Comments

@mleutenegger
Copy link
Member

mleutenegger commented Nov 18, 2020

Currently, commands like serve, down, run use the current directory as working direcory. When a User is in a subdirectory, this might cause problems with mounting said subdirectory or not correctly removing containers.

A simple solution would be to check wether the current working directory contains a composer.json file and is not located under vendors/ (as modules are not a valid project in most cases).

A PR must fulfill the following:

  • when executing up, down, serve, exec or run in a project containing a composer file, everything works correctly
  • when executing up, down, serve, exec or run in a directory of a vendor module, a warning is thrown that ssdev is not intended for use in modules
  • when executing up, down, serve, exec or run in any other directory, a warning is thrown that no project could be found
@mleutenegger mleutenegger self-assigned this Nov 19, 2020
@mleutenegger mleutenegger added the enhancement New feature or request label Nov 19, 2020
@mleutenegger mleutenegger changed the title ssdev should check for the presence of a project before executing docker compose Feature: when executing ssdev commands in subdirectories, there should be a warning when no project is present May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

1 participant