Skip to content

Commit b39491f

Browse files
committed
Remove similar trailer keys from commit hook
The duplicated "Close" and "Closes" keys will possibly cause inconsistency between commit messages. The one being kept is "Closes" because the implied subject is "this patch", so it should complete the following sentence: This patch [closes]... just like sentences in the body of a message. "Bug" is also removed due to its similarity to "Closes a bug". Change-Id: Idea7c0310249c603e550a7a4e27df490efe13d4c
1 parent c61139a commit b39491f

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

scripts/commit-msg.hook

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,7 @@ build_commit_trailer_regex() {
140140

141141
# Predefined trailer keys.
142142
trailers=(
143-
'CC' 'Change-Id'
144-
'Bug' 'Close' 'Closes'
143+
'CC' 'Change-Id' 'Closes'
145144
'Acked-by' 'Co-authored-by' 'Reported-by' 'Reviewed-by'
146145
'Signed-off-by' 'Suggested-by' 'Tested-by'
147146
)

0 commit comments

Comments
 (0)