Typescript Github Action shouldn't run from root directory #57
Labels
🐛 Bug
This isn't right...
🧹 Chore
Those pesky little things that don't fit any other tags
⚒️ CI/CD
Continuous integration/continuous deployment
🧠 Good 4 noobs
Good for newcomers
🆘 Help Needed
Help me pls <3
🌅 QOL
Quality of life improvement
Problem
Our
tsc
github action runs from the root directory and uses thetsconfig.json
in the root directory. This is a problem for a couple of reasons:tsconfig.json
in the project subdirectory anyways (eg.packages/ui/tsconfig.json
) for proper VSCode editor feature functioning otherwise you run into issues.Note
https://github.com/marketplace/actions/typescript-compiler is the github action we use for
tsc
. Note that there is a--project
parameter that should allow the action to be run from a subdirectory according to docs but I tried it and it didn't work for me. Maybe someone else can get it to work.Acceptance criteria
The
tsc
github action is modified such that a job is run for each package that contains atsconfig.json
. The job(s) will no longer run at the root level and any packages installed at the root level to please the github action can now be uninstalled. Or some other intelligent solution is put forward that solves the problems outlined above.The text was updated successfully, but these errors were encountered: