Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERR_DATA_CHANNEL error will be throw by SimplePeer and application level code cannot catch it. #35

Open
milochen0418 opened this issue Jan 25, 2021 · 1 comment

Comments

@milochen0418
Copy link

The SimpleSignalClient code will receive error randomly if another peer's website page refresh .

After checking this problem, we cannot catch this error.

Right now we can avoid this issue it by this way

Screen Shot 2021-01-25 at 10 07 13 PM

Because we cannot catch this error, so I try to avoid to throw it when ERR_DATA_CHANNEL error happen.

So we can at least implement dynamically peer remove/add in the room.

@milochen0418
Copy link
Author

The RTCErrorEvent will be throw as err in events/events.js if we don't handle peer('error').
So I put it in client code.

 
peer.on('error', (err)=>{
  console.log(err)
})

This is issue is solve by this pull request
#36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant