Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Add prepare npm hook #6

Open
d-asensio opened this issue Oct 4, 2018 · 1 comment
Open

Proposal: Add prepare npm hook #6

d-asensio opened this issue Oct 4, 2018 · 1 comment

Comments

@d-asensio
Copy link
Contributor

I think that it's not a good practice to commit distributable sources, since they use to be auto-generated and that could cause lots of git conflicts, and it's an unnecessary waste!

The solution could be:

  • Remove the "dist" folder from the repo.
  • Add the "dist" folder to the .gitignore file.
  • Add a npm hook (prepare) to generate the distributable sources right after publishing the package
  • Use GitHub's releases to allow users download the distributable files.
  • Document the process on the contributing guidelines.

I can do it! So I'll submit a PR if I have time

@t-mullen
Copy link
Owner

t-mullen commented Oct 4, 2018

You're absolutely right. Github Releases or an npm hook is the correct way to do this.

A PR would be welcome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants