-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture from Merger canvas appears blank when using getDisplayMedia #59
Comments
I can't reproduce. getDisplayMedia with a background tab works fine for me. It's possible it's OS specific - I've tried OSX 10.15.6 and Ubuntu 18. Are you using Windows (if so, which verison)? That JSFiddle errors for me with |
@t-mullen thanks for taking a look! Try this jsfiddle - I used the wrong link! I think it may well be a MediaRecorder issue, but without using that I'm not sure how to see the stream when the shared tab is foregrounded? |
Super weird, you don't even need to add the DisplayMedia stream to the merger cause this. It looks like This looks like a browser bug, but I'll see if I can get it working anyways. |
Odd! Is it worth reporting to the Chrome team? |
@t-mullen Sorry to be a pain - did you manage to get anywhere here, or can you shed any light on where I should go to next? Much appreciated! |
No, sorry - I wasn't able to find a workaround. Yes, this should be reported to the Chromium team. Be sure to include your jsfiddle for reproduction. |
I do not reproduce the issue using this sample: |
The issue is:
Will fix in #71 and add sample. |
Fixed in #71 via 92f0251 added demo also for debug see https://hthetiot.github.io/video-stream-merger/demo/p2p-screen.html |
Hi,
First off, thanks for the package!
I'm encountering a somewhat odd bug. I'm using
video-stream-merger
to let my customers narrate over top of a screen share. I was having problems where the audio and video would get out of sync, but this fixed it 😃However, I am encountering an odd potential bug. If you use
getDisplayMedia
and the user selects a non-frontmost Chrome tab, the output fromvideo-stream-merger
appears to be a black square (even though theMediaStream
itself has data).It doesn't look like an issue with the
captureStream
because I can use a customdraw()
function to draw a red circle (or anything) and that sticks around.Here's a jsfiddle with a minimal reproduction of the bug.
I have been trying everything here (order of creating the merger etc. etc) with no luck. Any help at this point is much appreciated! Hopefully this is a case of me doing something silly. Happy to work on a patch/fix too if anyone can point me in the right direction.
Cheers,
Nik
The text was updated successfully, but these errors were encountered: