Skip to content

Commit ba9fe6c

Browse files
committed
Follow-up to rails#16097 [ci skip]
Even if this is not exactly the same, let's add a new-line character instead of two spaces. While it's specified in the Markdown specs that adding spaces at the end of the line creates a break-line tag, this is a brittle approach as people may remove them saving the file on certain editors.
1 parent e44cb39 commit ba9fe6c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CONTRIBUTING.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,6 @@ Ruby on Rails is a volunteer effort. We encourage you to pitch in. [Join the tea
1212

1313
* If you have a change or new feature in mind, please [suggest it on the rubyonrails-core mailing list](https://groups.google.com/forum/?fromgroups#!forum/rubyonrails-core) and start writing code.
1414

15-
Thanks! :heart: :heart: :heart:
15+
Thanks! :heart: :heart: :heart:
16+
1617
Rails Team

guides/source/asset_pipeline.md

+6-3
Original file line numberDiff line numberDiff line change
@@ -124,19 +124,22 @@ with a built-in helper. In the source the generated code looked like this:
124124
The query string strategy has several disadvantages:
125125

126126
1. **Not all caches will reliably cache content where the filename only differs by
127-
query parameters**
127+
query parameters**
128+
128129
[Steve Souders recommends](http://www.stevesouders.com/blog/2008/08/23/revving-filenames-dont-use-querystring/),
129130
"...avoiding a querystring for cacheable resources". He found that in this
130131
case 5-20% of requests will not be cached. Query strings in particular do not
131132
work at all with some CDNs for cache invalidation.
132133

133-
2. **The file name can change between nodes in multi-server environments.**
134+
2. **The file name can change between nodes in multi-server environments.**
135+
134136
The default query string in Rails 2.x is based on the modification time of
135137
the files. When assets are deployed to a cluster, there is no guarantee that the
136138
timestamps will be the same, resulting in different values being used depending
137139
on which server handles the request.
138140

139-
3. **Too much cache invalidation**
141+
3. **Too much cache invalidation**
142+
140143
When static assets are deployed with each new release of code, the mtime
141144
(time of last modification) of _all_ these files changes, forcing all remote
142145
clients to fetch them again, even when the content of those assets has not changed.

0 commit comments

Comments
 (0)