Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes the field name from model to input_model in config schema #250

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Changes the field name from model to input_model in config schema #250

wants to merge 6 commits into from

Conversation

Sonu0305
Copy link
Contributor

@Sonu0305 Sonu0305 commented Feb 3, 2025

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Fixes #249

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Feb 3, 2025

Hi @jvshields @andrewfullard ,
Could you please review this when you have a chance,
Also does the file name have to be changed model.yml to input_model.yml, waiting feedback about any other required changes for this PR, Thank You.

@jvshields
Copy link
Contributor

Hi @jvshields @andrewfullard , Could you please review this when you have a chance, Also does the file name have to be changed model.yml to input_model.yml, waiting feedback about any other required changes for this PR, Thank You.

I do think it would be better to change the file name as well, but this looks good.

@Sonu0305
Copy link
Contributor Author

Sonu0305 commented Feb 4, 2025

@jvshields @andrewfullard ,
Changed the file name as well from model.yml to input_model.yml, Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvshields jvshields jvshields approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the config schema, change model to input_model
2 participants
@Sonu0305 @jvshields