Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure "previous iteration" values as simply inputs to the plasma #2878

Open
andrewfullard opened this issue Nov 12, 2024 · 2 comments
Open

Comments

@andrewfullard
Copy link
Contributor

Right now they are part of the plasma as special objects.

@karthik11135
Copy link

karthik11135 commented Jan 22, 2025

@andrewfullard
I was thinking of calculating the previous iteration values in the factory class and then pass as inputs (previous iteration properties array) to the base plasma. Can I do this?

Edit : I worked on this issue, I passed previous iteration properties array and prev output dict to baseplasma. However I'm still including prev iteration properties in the plasma modules.
If this is okay, I'll raise the PR. If not, I'm happy to make necessary changes.

@karthik11135
Copy link

Hi @andrewfullard,
This is just a follow up message. Kindly take a look at this approach when you are free.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants