Members 'Edit' own family breaks if family members are not visible

[jefft]

In Jethro's /members section home page, one sees members of one's own family, with an 'Edit' link to edit them:

However, say that:

• the current user is also a staff member
• the current user has their Jethro visibility restricted to a group or congregation
• one of their family members is not in that group/congregation

That person should probably not be visible, but they are. Until one clicks 'Edit', when Jethro breaks:

PHP message: Call to a member function getValue() on null - Line 37 of /home/jethro/code/2.36.0/app/members/views/view_0_edit_me.class.php

Should-not-be-visible family member's ID is being looked up, and the database view correctly returns nothing, which Jethro isn't expecting.

[tbar0970]

Hmm. The user is logged in with their member account, so restrictions on their control centre account shouldn't make a difference. I can look into this soon.

[tbar0970]

Ok, so Ive investigated and i now think your diagnosis is correct. But the intended behaviour is that control centre restrictions and members area visibility are separate things. Will investigate further.