Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag(...) does not supply "The Tag" just the closest tag in the tree and supresses important information. #21

Open
robshep opened this issue Feb 1, 2016 · 2 comments

Comments

@robshep
Copy link

robshep commented Feb 1, 2016

tag(...) does not supply "The Tag" just the closest tag in the tree and supresses important information.

Using --abbrev=0 means that a commit that is 10 away from the latest tag will not show LATEST-TAG-10 but only LATEST-TAG

This is wrong - the command should be fixed or called latestTag(...)

@tblobaum
Copy link
Owner

tblobaum commented Feb 3, 2016

@robshep thanks for bringing this up.

Is there any consensus on changing the name of the method?

@veselov
Copy link

veselov commented May 3, 2016

I just ran into this myself. IMHO, it's a bad idea to change the method name. I'd create a new method, call it objectTag, or currentTag, or something, and make it find out the tag if it points to HEAD. I don't know how to do that properly, actually, I used git tag --points xxx, where xxx is the output of git rev-parse HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants