Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateIntrinsics isn't passing prefix to CreateBuiltinFunction for builtin getters/setters #3534

Open
syg opened this issue Feb 10, 2025 · 2 comments
Labels

Comments

@syg
Copy link
Contributor

syg commented Feb 10, 2025

CreateIntrinsics should be passing the string prefix to its meta-call to CreateBuiltinFunction so builtin getters and setters are correctly named.

@syg syg added the spec bug label Feb 10, 2025
@jmdyck
Copy link
Collaborator

jmdyck commented Feb 10, 2025

Rather than adding even more prose to step 2 of CreateIntrinsics, maybe it would be better to replace

All values that are built-in function objects are created by performing CreateBuiltinFunction(steps, length, name, slots, realmRec, prototype) where steps is ..., name is ..., length is ..., slots is ..., and prototype is ....

with something like:

All values that are built-in function objects are created by invoking CreateBuiltinFunction as specified in [18 ECMAScript Standard Built-in Objects].

The latter location goes into more detail and has the advantage of not cramming it all into one algorithm step.

@jmdyck
Copy link
Collaborator

jmdyck commented Feb 10, 2025

See PR #2833.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants