Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NudgeToZonedTime: AddTimeDuration and AdjustDateDurationRecord are infallible #3030

Closed
anba opened this issue Oct 30, 2024 · 0 comments
Closed

NudgeToZonedTime: AddTimeDuration and AdjustDateDurationRecord are infallible #3030

anba opened this issue Oct 30, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Oct 30, 2024

NudgeToZonedTime, step 11:

  1. Let beyondDaySpan be ? AddTimeDuration(roundedTimeDuration, -daySpan).

This reduces the absolute value of roundedTimeDuration and therefore can't fail.

NudgeToZonedDateTime, step 14:

  1. Let dateDuration be ? AdjustDateDurationRecord(duration.[[Date]], duration.[[Date]].[[Days]] + dayDelta).

duration is the difference between two ZonedDateTime, so adding ±1 won't overflow the valid duration limits.
@ptomato ptomato self-assigned this Dec 5, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 5, 2024
ptomato added a commit that referenced this issue Dec 5, 2024
@ptomato
Editorial: AddTimeDuration in NudgeToZonedTime is infallible
cbe68cf 
This only reduces the absolute value of roundedTimeDuration, so it's
impossible for it to go beyond the limit.

h/t Anba

Closes: #3030
ptomato added a commit that referenced this issue Dec 5, 2024
@ptomato
Editorial: AdjustDateDurationRecord in NudgeToZonedTime is infallible
3fbfc4a 
The date duration is the difference between two ZonedDateTimes, so cannot
be anywhere near the limit. Therefore, it's impossible that adding 1 day
could take it over the limit.

h/t Anba

Closes: #3030
@Ms2ger Ms2ger closed this as completed in 7aef51e Dec 5, 2024
Ms2ger pushed a commit that referenced this issue Dec 5, 2024
@ptomato @Ms2ger
Editorial: AdjustDateDurationRecord in NudgeToZonedTime is infallible
35cc12d 
The date duration is the difference between two ZonedDateTimes, so cannot
be anywhere near the limit. Therefore, it's impossible that adding 1 day
could take it over the limit.

h/t Anba

Closes: #3030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba