Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NudgeToDayOrTime: AdjustDateDurationRecord is infallible #3033

Closed
anba opened this issue Nov 1, 2024 · 0 comments
Closed

NudgeToDayOrTime: AdjustDateDurationRecord is infallible #3033

anba opened this issue Nov 1, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Nov 1, 2024

NudgeToDayOrTime, step 14:

  1. Let dateDuration be ? AdjustDateDurationRecord(duration.[[Date]], days).

days is either zero or roundedWholeDays. When zero, AdjustDateDurationRecord is trivially infallible. When roundedWholeDays, then it's also infallible, because roundedWholeDays is truncate(DivideTimeDuration(roundedNorm, nsPerDay)) and roundedNorm is a valid time duration.
@ptomato ptomato self-assigned this Dec 5, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Dec 5, 2024
ptomato added a commit that referenced this issue Dec 5, 2024
@ptomato
Editorial: AdjustDateDurationRecord in NudgeToDayOrTime is infallible
61fb206 
Quoting Anba: days is either zero or roundedWholeDays. When zero,
AdjustDateDurationRecord is trivially infallible. When roundedWholeDays,
it's also infallible, because roundedWholeDays is
truncate(DivideTimeDuration(roundedNorm, nsPerDay)) and roundedNorm is a
valid time duration.

Closes: #3033
@Ms2ger Ms2ger closed this as completed in 2637ba5 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba