-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TG2 - Test Specifications and definitions #174
Comments
Lee - I have altered ACTION to RESPONSE as earlier discussed |
Note @Tasilee - we have just "Description" in Amendments and Measures - not a "Pass Description" and a "Fail Description" |
I realised that we didn't have specifics of the subset of terms used within the TG2 test issues. This is a placeholder. In doing this draft, inconsistencies in the labels and with the TG1 Framework became apparent. For example, some but not all Darwin Core terms are hyphenated in the Term component of the labels. e.g., #55, #56, #68 and #107 have been edited for consistency. There are however, also inconsistencies with those tests that have the (now called) "Response" value "FROM_XXXYYY" where "XXXYYY" can be one or more Darwin Core terms. I suggest for consistency, we use "FROM-XXX-YYY"? Regards TG1-TG2, there is no "Likeliness" in the Framework DQ Dimension and some of the definitions are more global than the TG2 context. Please edit the table above if you think there are better definitions and/or examples. |
@ArthurChapman regards "Pass description"/"Fail description", yep, I know. This was just a draft that I needed to Save before it got too complex. I also need to add an example "Example implementation" and "Link to specification code": They were hard to find - so we may need a few more TAGs that designate "Done X" |
@Tasilee great to have definitions of these. Also see the (trivial, special purpose) code (at https://github.com/kurator-org/bdq_issue_to_csv/blob/master/src/main/java/org/kurator/issueconverter/BDQConvert.java for manipulating these tables in the github issues into CSV suitable for alignment with the RDF representation of the framework. Note that InformationElement is singular in the framework, even though an InformationElement may be comprised of a list of DarwinCore terms. DarwinCore class is in effect a category for the InformationElement. It is probably worth separating the examples into a separate column, and adding a column to map these values to framework concepts (e.g. Information Elements = InformationElement, Data Quality Dimension = Dimension). |
What we probably need, rather than (or in addition to) this, is the definitions of the column headers in the spreadsheet produced by the BDQConvert code (as that is bringing the tests into closer alignment with the framework). |
@chicoreus - again we seem to have a problem with Framework Definitions and having multiple documents with conflicting information. the Glossary at https://tdwg.github.io/bdq/tg1/site/glossary.html which I and others thought was the current up-to-date version has DQ Dimension not just Dimension and Information Element not InformationElement |
I am really glad to see this coming together. Reviewing it keeps us on our toes. It made me ponder a number of issues when I think about taking the information provided and turning it into code. I made an issue #175 to discuss the merits of defining expected responses for the tests. |
In discussion with @ArthurChapman this morning, I decided to update the specifications above to match the current implementation. The terms and definitions should also conform to the Vocabulary #152. |
The text was updated successfully, but these errors were encountered: